First of all, let me pretence this my stating I'm in New Zealand where the predominate connection to aDSL is using PPPoA, not PPPoE as many routers support. I recently purchased an ASUS RT-AC68U router but if you use one of these in NZ piggybacked onto an ISP provided modem and you leave your new router set to 'Wireless Router Mode (default), you will end up in a double NAT scenario and in even more trouble if you had devices behind your firewall that you used to access from outside your network as these will no longer be accessible.
My collection of Home Assistant, CoreELEC, IoT, Synology, Kodi and other technical tips gathered over the years.